Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #28 Implement execution/constants.go & execution/execution.go #61

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ABD-AZE
Copy link

@ABD-AZE ABD-AZE commented Sep 23, 2024

Resolves #28

  1. The code is not compiling as of now as there are errors which need to be resolved
  2. All caller functions which are exposed as the client side functions have been wrapped inside go routines.
  3. for H256 type I have used geth's Hash type from the common package (github.com/ethereum/go-ethereum/common.Hash)
  4. Function name consistency and argument type consistency is to be ensured in the pakcages state.go , rpc.go and proof.go as functions from these are used in the execution.go file.
  5. The functions dealing with Filter have not been implemented as I am not sure whether to define the filter type and all its methods ( that would be very tedious: https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/types/filter.rs). I have checked geth for something similar to the filter type but nothing found.
  6. Another thing which I am unsure of is the receipt root calculation, in helios they have used an external crate (https://docs.rs/triehash/latest/triehash/fn.ordered_trie_root.html) which only takes the vector as an input and generates the root hash. I have written the function for calculating the receipt root but i am not sure of its correctness.

@gerceboss
Copy link
Contributor

@ABD-AZE , for the 6th you can write unit test to check the correctness for now. Also which rpc.go are you talking about??? I don't see any issue created for the execution module

@gerceboss
Copy link
Contributor

@ABD-AZE , don't you think the person writing rpc.go for execution will have to define the Filter type as well?

@ABD-AZE
Copy link
Author

ABD-AZE commented Sep 29, 2024

??? I don't see any issue created for

Rpc.go is not issued yet but it would be in the future.

@ABD-AZE
Copy link
Author

ABD-AZE commented Sep 29, 2024

The Filter type used in Helios has been imported from some external crate. For our use I think we would have to define filter type on our own, so what should I do? (I think a separate issue can be assigned to change the types.go file to include the filter type and it's methods)

@gerceboss
Copy link
Contributor

@ABD-AZE , FilterQuery is defined in Geth and is used to filer logs. This might work out

@ABD-AZE
Copy link
Author

ABD-AZE commented Oct 2, 2024

Okay I'll check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants